On Fri, Jun 29, 2012 at 01:49:21PM -0500, Omar Ramirez Luna wrote:
> And silence the following warning:
>
> drivers/staging/tidspbridge/pmgr/dbll.c:
> In function 'dbll_rmm_alloc':
> drivers/staging/tidspbridge/pmgr/dbll.c:1124:
> warning: ignoring return value of 'kstrtol',
> declared with attribute warn_unused_result
>
> Since the code is using strict_strol it was replaced for kstrtol
> as the former is obsolete now.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@xxxxxxxxxx>
> ---
> drivers/staging/tidspbridge/pmgr/dbll.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/tidspbridge/pmgr/dbll.c b/drivers/staging/tidspbridge/pmgr/dbll.c
> index 9f07036..3858aa1 100644
> --- a/drivers/staging/tidspbridge/pmgr/dbll.c
> +++ b/drivers/staging/tidspbridge/pmgr/dbll.c
> @@ -1120,8 +1120,11 @@ static int dbll_rmm_alloc(struct dynamic_loader_allocate *this,
> or DYN_EXTERNAL, then mem granularity information is present
> within the section name - only process if there are at least three
> tokens within the section name (just a minor optimization) */
> - if (count >= 3)
> - strict_strtol(sz_last_token, 10, (long *)&req);
> + if (count >= 3) {
> + ret = kstrtol(sz_last_token, 10, (long *)&req);
req is an s32 so this will corrupt memory on a 64 bit system. One
option would be to use.
ret = kstrtos32(sz_last_token, 10, &req);
But maybe a better option might be to change the type of "req" to
some more normal C type if there isn't a specific reason for it to
be s32.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
