[PATCH 5/5] staging: tidspbridge: check the return value of kstrtol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



And silence the following warning:

drivers/staging/tidspbridge/pmgr/dbll.c:
    In function 'dbll_rmm_alloc':
drivers/staging/tidspbridge/pmgr/dbll.c:1124:
    warning: ignoring return value of 'kstrtol',
    declared with attribute warn_unused_result

Since the code is using strict_strol it was replaced for kstrtol
as the former is obsolete now.

Signed-off-by: Omar Ramirez Luna <omar.ramirez@xxxxxxxxxx>
---
 drivers/staging/tidspbridge/pmgr/dbll.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/tidspbridge/pmgr/dbll.c b/drivers/staging/tidspbridge/pmgr/dbll.c
index 9f07036..3858aa1 100644
--- a/drivers/staging/tidspbridge/pmgr/dbll.c
+++ b/drivers/staging/tidspbridge/pmgr/dbll.c
@@ -1120,8 +1120,11 @@ static int dbll_rmm_alloc(struct dynamic_loader_allocate *this,
 	   or DYN_EXTERNAL, then mem granularity information is present
 	   within the section name - only process if there are at least three
 	   tokens within the section name (just a minor optimization) */
-	if (count >= 3)
-		strict_strtol(sz_last_token, 10, (long *)&req);
+	if (count >= 3) {
+		ret = kstrtol(sz_last_token, 10, (long *)&req);
+		if (ret)
+			goto func_cont;
+	}
 
 	if ((req == 0) || (req == 1)) {
 		if (strcmp(sz_sec_last_token, "DYN_DARAM") == 0) {
-- 
1.7.4.1

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux