On Tue, Jun 26, KY Srinivasan wrote: > > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > The fact that it was Red Hat specific was the main part, this should be > > done in a standard way, with standard tools, right? > > The reason I asked this question was to make sure I address these > issues in addition to whatever I am debugging now. I use the standard > tools and calls to retrieve all the IP configuration. As I look at > each distribution the files they keep persistent IP configuration > Information is different and that is the reason I chose to start with > RedHat. If there is a standard way to store the configuration, I will > do that. KY, instead of using system() in kvp_get_ipconfig_info and kvp_set_ip_info, wouldnt it be easier to call an external helper script which does all the distribution specific work? Just define some API to pass values to the script, and something to read values collected by the script back into the daemon. If the work is done in a script it will be much easier for an admin to debug and adjust it. I think there is no standard way to configure all relevant distros in the same way. Maybe one day NetworkManager can finally handle all possible ways to configure network related things. But until that happens the config files need to be adjusted manually. Some of the functions have deep indention levels due to 'while() { switch() }' usage. Perhaps such code could be moved into its own function so that lines dont need to be wrapped that much due to the odd 80 column limit. Olaf _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
