On Tue, Jun 26, 2012 at 10:07:27AM +0100, Rupesh Gujare wrote: > On 21/06/12 14:58, Greg KH wrote: > >> > >>Thanks for accepting this series. > >> > >>I will be happy if you (or someone on list) can guide me to get this > >>driver out of staging. > >>I will be happy to understand what you expect is sufficient enough > >>to move this driver out of staging. > >> > >>Following are changes that I am planning to make it cleaner. I will > >>be updating TODO file soon. > >>1. Check for remaining ioctl & check if that can be converted into > >>sysfs entries. > >>2. convert trace prints to appropriate dev_debug or something better. > >>3. Modify Kconfig to add CONFIG option for enabling/disabling event tracing. > >These are all good things to do, except that you should probably remove > >the event tracing code, or move it to the in-kernel tracing > >infrastructure, don't duplicate existing functionality in different > >ways. > > > >Do those, and then we will be glad to review it for inclusion in the > >drivers/usb/ portion of the kernel. > > > > > Greg, > > Thanks for your feedback. > > Event tracing code is quiet important to us during development & > debugging. As per your suggestion I will work on > to move event tracing code to in-kernel tracing infrastructure. Great. > To make sure that I am heading in right direction, can you please > confirm that following is in-kernel tracing infrastructure ? > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=Documentation/trace/tracepoints.txt;h=c0e1ceed75a441b692bf447b3fcdc49d8abdd1cc;hb=HEAD Yes, that's the one. Also look at the ftrace.txt file in Documentation/trace/ as well, I think a lot of your existing "trace points" can be removed because of the built-in infrastructure already. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
