Re: [PATCH 1/6] staging: ozwpan: ISOC transfer in triggered mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/06/12 00:05, Greg KH wrote:
On Wed, Jun 20, 2012 at 01:36:06PM +0100, Rupesh Gujare wrote:
This patch implements ISOC frame transfer while PD is in
  triggered mode.

Signed-off-by: Rupesh Gujare<rgujare@xxxxxxxxxxxxxxx>
It's great to see new features for this driver, but I really would like
to see it move out of drivers/staging before adding any new features to
it.

So I'll take this series, but from now on, please work on getting it
cleaned up and out of drivers/staging/ and then you can add new features
to it.

thanks,

greg k-h

Greg,

Thanks for accepting this series.

I will be happy if you (or someone on list) can guide me to get this driver out of staging. I will be happy to understand what you expect is sufficient enough to move this driver out of staging.

Following are changes that I am planning to make it cleaner. I will be updating TODO file soon. 1. Check for remaining ioctl & check if that can be converted into sysfs entries.
2. convert trace prints to appropriate dev_debug or something better.
3. Modify Kconfig to add CONFIG option for enabling/disabling event tracing.

At the moment driver is quiet upto linux coding style standard, however I will be happy to work on it, if it still needs modifications.

--
Regards,
Rupesh Gujare


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux