On Sun, Jun 03, 2012 at 10:34:35AM +0200, Marc Dietrich wrote: > On Saturday 02 June 2012 23:38:19 Dan Carpenter wrote: > > On Sat, Jun 02, 2012 at 03:10:52PM +0200, Marc Dietrich wrote: > > > Hi Adnan, > > > > > > On Monday 28 May 2012 10:41:24 Adnan Ali wrote: > > > > This commit fixes coding style issues that includes > > > > long lines. > > > > > > I included your and some more style fixes to V2 of the "nvec cleanup" > > > series. > > Gar. That's not the right way. > > > > No one has replied to your v1 patches, so probably we will apply > > them first. Once they are applied it's set in stone. > > The fact that no one replied, doesn't mean that I cannot revise it myself if I > find problems. AFAIK, we are not in staging merge window yet, so applying a > revised version shouldn't be a problem. Maybe I should have replied to the > first version to make clear that it is obsolete. > Yes. It's still not too late to do this, in fact. I would, but I figure it will serve as a valuable lesson on proper communication if nobody replies to the thread and they get applied and you have to create a v4. ;) > > I assume that > > Adnan's patches don't apply on top of the v1 patches and that's why > > you redid yours? It would have been better to just say something > > like, "Hi Adnan, these patches won't apply on top of my earlier > > patches <url>. Please can you redo them?" > > Don't know what drove me, sorry. I'm going to rebase my patches ontop of his > one and submit a third version. > That's probably best. Part of the big trick of kernel development is working with other developers. It's sometimes not clear which patches are going to be applied so you have to patch on top of them. It's sometimes the right thing to fold patches together. It's sometimes the right thing to say, "This patch conflicts with something I'm working on. I'll pick it up and forward it on to Greg as part of my patchset at the end of the week." (It's not OK to delay for more than few days.) Always give as much credit as you can. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
