Re: [PATCH] Staging: nvec: fix coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 02, 2012 at 03:10:52PM +0200, Marc Dietrich wrote:
> Hi Adnan,
> 
> On Monday 28 May 2012 10:41:24 Adnan Ali wrote:
> > This commit fixes coding style issues that includes
> > long lines.
> 
> I included your and some more style fixes to V2 of the "nvec cleanup" series.
> 

Gar.  That's not the right way.

No one has replied to your v1 patches, so probably we will apply
them first.  Once they are applied it's set in stone.  I assume that
Adnan's patches don't apply on top of the v1 patches and that's why
you redid yours?  It would have been better to just say something
like, "Hi Adnan, these patches won't apply on top of my earlier
patches <url>.  Please can you redo them?"  There was no need to
send a v2 patchset when you could have just sent the 6/6 patch by
itself instead of resending 1-5.

It's a tricky thing when it's appropriate to fold someone's patch
into your work.  I don't think it was the right thing here.  At
least give credit when you do.

So obviously this is a small patch, but whatever, just work work
with the system and everything goes more smoothly.

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux