On Thu, May 24, 2012 at 04:15:38PM +0100, Ian Abbott wrote:
> On 2012-05-23 21:22, Dan Carpenter wrote:
> >On Wed, May 23, 2012 at 05:50:28PM +0100, Ian Abbott wrote:
> >>+
> >>+#if IS_ENABLED(CONFIG_COMEDI_DAS08_PCI)
> >>+static const struct das08_board_struct
> >>+*das08_find_pci_board(struct pci_dev *pdev)
> >
> >Normally the * would go on the first line.
> >
> >static const struct das08_board_struct *
> >das08_find_pci_board(struct pci_dev *pdev)
> >
> >That way before cscope was around you can grep for functions by
> >doing: egrep -B1 '^[a-z]+\(' *.c
> >
> >There are 30 some places in the kernel which put the * on the second
> >line but they are mostly in ugly subsystems.
>
> CodingStyle section 3.1 suggests it should be adjacent to the function name.
>
That's if you want to declare it like this:
static const struct das08_board_struct *das08_find_pci_board(
struct pci_dev *pdev)
{
....
Which is also fine.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
