Re: [PATCH 9/9] staging: comedi: das08: Add attach_pci() hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012-05-23 21:22, Dan Carpenter wrote:
On Wed, May 23, 2012 at 05:50:28PM +0100, Ian Abbott wrote:
+
+#if IS_ENABLED(CONFIG_COMEDI_DAS08_PCI)
+static const struct das08_board_struct
+*das08_find_pci_board(struct pci_dev *pdev)

Normally the * would go on the first line.

static const struct das08_board_struct *
das08_find_pci_board(struct pci_dev *pdev)

That way before cscope was around you can grep for functions by
doing:  egrep -B1 '^[a-z]+\(' *.c

There are 30 some places in the kernel which put the * on the second
line but they are mostly in ugly subsystems.

CodingStyle section 3.1 suggests it should be adjacent to the function name.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux