On Fri, 2012-05-18 at 17:37 -0700, Greg Kroah-Hartman wrote:
[...]
> > if (dev->slot >= TPCI200_NB_SLOT) {
> > - pr_info("Slot [%s %d:%d] doesn't exist! Last tpci200 slot is %d.\n",
> > - TPCI200_SHORTNAME, dev->bus_nr, dev->slot,
> > - TPCI200_NB_SLOT-1);
> > + pr_info("Slot [%d:%d] doesn't exist! Last tpci200 slot is %d.\n",
> > + dev->bus_nr, dev->slot, TPCI200_NB_SLOT-1);
>
> All of these should really be dev_err() calls, right?
>
> You should have no pr_* calls at all in any driver, and probably none in
> the ipack core as well, care to fix them all up?
Yes, I will fix it in the next bunch of patches. I don't forget it.
By the way, sometime ago, you suggested me to use the ics interface for
giving the bus number if there is no HW boundary of the number of them.
However, I searched the source code and I didn't find any reference to
the ics interface. Can you tell me where is it declared?
Thanks,
Sam
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
