On Fri, May 18, 2012 at 11:10:07AM +0200, Samuel Iglesias Gonsalvez wrote:
> Removed TPCI200_SHORTNAME. For the pr_* the name of the module is already
> included due to pr_fmt declaration.
>
> In other cases, KBUILD_MODNAME is used instead.
>
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>
> ---
> drivers/staging/ipack/bridges/tpci200.c | 70 +++++++++++++++----------------
> drivers/staging/ipack/bridges/tpci200.h | 2 -
> 2 files changed, 33 insertions(+), 39 deletions(-)
>
> diff --git a/drivers/staging/ipack/bridges/tpci200.c b/drivers/staging/ipack/bridges/tpci200.c
> index b460587..c043345 100644
> --- a/drivers/staging/ipack/bridges/tpci200.c
> +++ b/drivers/staging/ipack/bridges/tpci200.c
> @@ -54,16 +54,15 @@ static struct tpci200_board *check_slot(struct ipack_device *dev)
> }
>
> if (dev->slot >= TPCI200_NB_SLOT) {
> - pr_info("Slot [%s %d:%d] doesn't exist! Last tpci200 slot is %d.\n",
> - TPCI200_SHORTNAME, dev->bus_nr, dev->slot,
> - TPCI200_NB_SLOT-1);
> + pr_info("Slot [%d:%d] doesn't exist! Last tpci200 slot is %d.\n",
> + dev->bus_nr, dev->slot, TPCI200_NB_SLOT-1);
All of these should really be dev_err() calls, right?
You should have no pr_* calls at all in any driver, and probably none in
the ipack core as well, care to fix them all up?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
