Re: [PATCH 1/2] staging: zcache: fix length type mismatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 28, 2012 at 04:01:37PM -0600, Seth Jennings wrote:
> This fixes a type mismatch in the compression code where
> a size_t pointer was cast to a unsigned int pointer.  On
> little endian archs, there is no issue.  However on big
> endian archs, the value is incorrect, taking the high
> order bits and truncating the lower order bits.

I would think this would be a problem on any 64bit machine not just
big endian ones.  Since clen is half uninitialized we would likely
hit the clen > zbud_max_buddy_size() test.

Anyway the patch is right.

regards,
dan carpenter


Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux