On Wed, Feb 29, 2012 at 04:34:51AM +0100, Oliver N. Baumann wrote:
> From: "Oliver N. Baumann" <baumanno@xxxxxxxxxxxxxx>
>
> This is a patch to asus_oled.c that fixes a parenthesis issue detected by checkpatch.pl tool
> Signed-off-by: Oliver N. Baumann <baumanno@xxxxxxxxxxxxxx>
You need a blank line between the changelog text and the signed-off-by
line.
Also, please wrap your changelog entry at 72 columns.
But most of all:
> ---
> drivers/staging/asus_oled/asus_oled.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
> index 1df9586..b77f225 100644
> --- a/drivers/staging/asus_oled/asus_oled.c
> +++ b/drivers/staging/asus_oled/asus_oled.c
> @@ -44,9 +44,9 @@
>
> #define ASUS_OLED_ERROR "Asus OLED Display Error: "
>
> -#define ASUS_OLED_STATIC 's'
> -#define ASUS_OLED_ROLL 'r'
> -#define ASUS_OLED_FLASH 'f'
> +#define ASUS_OLED_STATIC ('s')
> +#define ASUS_OLED_ROLL ('r')
> +#define ASUS_OLED_FLASH ('f')
That's not a valid change, checkpatch is being stupid here, please use
your judgement. This patch changes nothing, go bug the checkpatch
people to fix their tool.
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
