On Sat, Feb 18, 2012 at 12:23:16PM +0530, Prashant Shah wrote: > Hi, > > I have been working on connecting a USB to I2C communication module > from Silicon Labs - Si700x. > > It consists of a temperature and humidity sensor which connects > through I2C bus. Si700x is a evaluation module that converts the I2C > data to USB which is then sent to the PC. I need feedback on the > driver code which is uploaded on github.com. > > Sensor -> I2C -> Si700x Evaluation Board (I2C to USB) -> USB -> PC > > git repo : https://github.com/prashants/si700x > > driver file : https://github.com/prashants/si700x/blob/master/si700x.c Why not post a patch so we can properly review and provide comments in a much easier manner? Please see the file Documentation/SubmittingDrivers for why pointing people at a url is not useful. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
