Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> It's possible to add "%s...", __func__ to
> the necessary uses.  Adding it to the generic
> is likely overkill.
I agree with that.

> But is it really necessary anyway?
>
> Aren't those called via some specific notifier
> such that the output would make sense given
> some specific invalid input?
Some messages like "Invalid Arg" and "Invalid len" really don't make
sense as it is.

But I think that just adding __func__ to the necessary uses is enough.
I will resend this patch.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux