On Sat, 2012-01-21 at 11:22 -0800, sam hansen wrote: > > One other thing. It would be better to add > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > before any #include and convert all the > > printks(KERN_<LEVEL> to pr_<level>( > > stripping all the leading XGIfb: too. > > So, an administrative question. Sorry for my noob-ishness but... I > will be 1) modifying the patch regarding prink to use pr_LVL (and a > few logic tweaks), and will also be introducing a new patch to set up > the pr_fmt macro for kbuild. I can find lots of information regarding > how to create/submit a patch, but not a lot of information about how > to modify/resubmit a patch you've already submitted and received > feedback for. Rework the commented things in a new branch. Apply the patches to the new branch one at a time, modify as necessary then git commit --amend the appropriately changed files while modifying change logs. Then resubmit with git format-patch --subject-prefix="PATCH V2" You could also add --in-reply-to=originalemailid > The pr_fmt patch will likely just be a new patch outside of this patch > set? A new patch would be fine. Here's a little regex based tool for part of that conversion http://lwn.net/Articles/380161/ An example would be: $ ./scripts/cvt_kernel_style.pl \ --convert=convert_printk_to_pr_level \ -o drivers/staging/xgifb/XGI_main_26.c _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
