> One other thing. It would be better to add > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > before any #include and convert all the > printks(KERN_<LEVEL> to pr_<level>( > stripping all the leading XGIfb: too. So, an administrative question. Sorry for my noob-ishness but... I will be 1) modifying the patch regarding prink to use pr_LVL (and a few logic tweaks), and will also be introducing a new patch to set up the pr_fmt macro for kbuild. I can find lots of information regarding how to create/submit a patch, but not a lot of information about how to modify/resubmit a patch you've already submitted and received feedback for. The pr_fmt patch will likely just be a new patch outside of this patch set? Or should I use git-rebase to work it in the middle of the patch set and regenerate/resend all patches (this approach doesn't seem to make sense). I'm not sure how the git commit short-hashes work with the patches, and I don't want to destroy that information because it seems like it's important when stuff goes upstream? Thanks for any feedback you guys may have :) And thanks for helping me pull myself up to actually being useful to you all. ~s _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
