It still complains about the following macros where parenthesis are not needed. ERROR: Macros with complex values should be enclosed in parenthesis #156: FILE: staging/android/pmem.c:156: +#define PMEM_IS_FREE(id, index) !(pmem[id].bitmap[index].allocated) Let's just make the check look for an operator with a low precedence. http://en.wikipedia.org/wiki/Order_of_operations#Programming_languages Otherwise the submitters are going to change it to: #define PMEM_IS_FREE(id, index) (!(pmem[id].bitmap[index].allocated)) That has two pairs of unneeded paranthesis and we run the risk of reprogramming the kernel in lisp, by mistake. regards, dan carpenter
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
