Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and other formating issues pointed out by checkpatch.pl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 17, 2012 at 07:19:19PM -0800, Pradheep wrote:
> This patch fixes the formating and other trival formatting issues pointed out by checkpatch.pl
> 
> Signed-off-by:pradheep.shrinivasan@xxxxxxxxx

The format should be:

Signed-off-by: Your Name <email@xxxxxxxxxxx>

> ---
>  drivers/staging/android/android_pmem.h |   17 ++++++++---------
>  1 files changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/android/android_pmem.h b/drivers/staging/android/android_pmem.h
> index f633621..5dd332f 100644
> --- a/drivers/staging/android/android_pmem.h
> +++ b/drivers/staging/android/android_pmem.h
> @@ -7,7 +7,7 @@
>   * may be copied, distributed, and modified under those terms.
>   *
>   * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of 
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   * GNU General Public License for more details.
>   *
> @@ -16,7 +16,7 @@
>  #ifndef _ANDROID_PMEM_H_
>  #define _ANDROID_PMEM_H_
>  
> -#define PMEM_IOCTL_MAGIC 'p'
> +#define PMEM_IOCTL_MAGIC ('p')

You don't need parenthesis here.  Did checkpatch really complain
about this?

regards,
dan carpenter


Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux