Re: [PATCH 1/6] Staging: bcm: Fix coding style issues in CmHost.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 3, 2012 at 1:14 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Mon, Jan 02, 2012 at 11:17:16PM -0500, Kevin McKinney wrote:
>>               case eDeletePHSRule:
>>               {
>> -                     BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL,"PHS DSC Action = Delete PHS Rule \n");
>> +                     BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL, "PHS DSC Action = Delete PHS Rule\n");
>>
>> -                     if(psfCSType->cPhsRule.u8PHSI)
>> -                     {
>> -                             PhsDeletePHSRule(
>> -                                     &Adapter->stBCMPhsContext,
>> -                                     uVCID,
>> -                                     psfCSType->cCPacketClassificationRule.u8AssociatedPHSI);
>> -                     }
>> +                     if (psfCSType->cPhsRule.u8PHSI)
>> +                             PhsDeletePHSRule(&Adapter->stBCMPhsContext, uVCID, psfCSType->cCPacketClassificationRule.u8AssociatedPHSI);
>>                       else
>> -                     {
>> -                             //BCM_DEBUG_PRINT(CONN_MSG,("Error CPHSRule.PHSI is ZERO \n"));
>> -                     }
>> +                             /* BCM_DEBUG_PRINT(CONN_MSG,("Error CPHSRule.PHSI is ZERO\n")); */
>> +
>>                       break;
>
>
> This is broken.  You removed the empty curly braces so now onle the
> else statement breaks.  You have to remove the else statement as
> well.
>
Okay - I will fix this and resubmit all six patches. Thanks for catching this.

Thanks,
Kevin
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux