On Tue, Jan 3, 2012 at 3:32 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Mon, Jan 02, 2012 at 11:17:21PM -0500, Kevin McKinney wrote: >> This patch replaces unnecessarily long local variables >> used in for loops with more compact i and/or x for >> readability purposes. > > I would say that "x" is almost always a bad name for a variable. > Traditionally if you have two loops, then you might use "i" for the > outside iterator and "j" for the inside iterator. But really it's > often better to name your iterators in that case so there is no > confusion. > > Many of these iterators don't need to be initialized. Iterators > should be type "int" by default unless something extra special is > going on. > Okay, yeah - that makes sense. I will change these variables back to the original name. Thanks, Kevin _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
