On Sun, Dec 04, 2011 at 11:12:46PM -0200, Marcos Paulo de Souza wrote: > This patch change all references of BOOL to int. As asked by the TODO > file of the driver, we need to remove the ttype.h, and this file do a > typedef of int to BOOL. We don't need this. > Why not use bool? Especially inside structs bool takes up less space than an int. Also static analysis tools care about the type. Changing the type from int to bool is a code change so it needs careful auditing. It's not a problem if you don't have this hardware, but you've been sending quite a few patches for it, so I'm curious if you do? If you did, and you made a code change then it helps us to know if you have tested it. regards, dan carpenter
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
