Re: [PATCH 05/20] staging: xgifb: ReadVBIOSTablData(): use a pointer to access the array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 04, 2011 at 08:46:47PM +0200, Aaro Koskinen wrote:
> Use a pointer variable to make some lines shorter and more readable.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> ---
> +		lvds->PSC_S5		= vbios[i + 24];
>  		i += 25;
>  		j--;
>  		k++;
> +		lvds++;


Incrementing lvds here is a bugfix yes?  The original code just set
the first element of the array over and over.

>  	} while (j > 0 && k < ARRAY_SIZE(XGI21_LCDCapList));
>  }
>  

regards,
dan carpenter


Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux