Re: [PATCH 13/15] Export task_prio to modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 01, 2011 at 04:22:49PM -0500, Mathieu Desnoyers wrote:
> * Mathieu Desnoyers (mathieu.desnoyers@xxxxxxxxxxxx) wrote:
> > * Greg KH (greg@xxxxxxxxx) wrote:
> > > On Wed, Nov 30, 2011 at 01:34:26PM -0500, Mathieu Desnoyers wrote:
> > > > LTTng needs this symbol to prepend the current task dynamic priority
> > > > value to events (optional context information).
> > > > 
> > > > Exporting to all modules following the similar task_nice().
> > > > 
> > > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
> > > > ---
> > > >  kernel/sched.c |    1 +
> > > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/kernel/sched.c b/kernel/sched.c
> > > > index 0e9344a..ac88d6c 100644
> > > > --- a/kernel/sched.c
> > > > +++ b/kernel/sched.c
> > > > @@ -5142,6 +5142,7 @@ int task_prio(const struct task_struct *p)
> > > >  {
> > > >  	return p->prio - MAX_RT_PRIO;
> > > >  }
> > > > +EXPORT_SYMBOL(task_prio);
> > > 
> > > Any reason why this isn't EXPORT_SYMBOL_GPL()?
> > > 
> > 
> > Because task_nice, very similar in spirit to task_prio, is
> > EXPORT_SYMBOL. But if you feed it would be better to have a "_GPL" here,
> > I'll add it.
> 
> Hrm, but you know what ? Given I prefer things to go smoothly, I'll make
> all these exports "_GPL".

That would be a good idea :)

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux