Hi Greg, Here is the cleanup of the LTTng wrappers that used kallsyms to lookup some kernel symbols. I introduce the missing symbols in the mainline kernel, trying to follow the local exports already in place when it comes to choosing between EXPORT_SYMBOL and EXPORT_SYMBOL_GPL. I also removed wrappers that deal with API changes across kernel versions (for older kernels). Only few wrapper files are left at this point (TODO), but those are less repulsive than those that used kallsyms: - inline_memcpy.h: ensures that inline_memcpy is declared on all architectures. - poll.h: see TODO file, "Features" section. - trace-clock.h: see TODO file, "Features" section. - ringbuffer: those are internal to the driver. They were there to make it easier to switch between the ringbuffer deployed in my own kernel tree and the module-specific ringbuffer. The 3 first patches are small cleanups recommended to me by a static checker. Diffstat: b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_frontend.c | 6 b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c | 3 drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c | 3 b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_vfs.c | 3 b/mm/nommu.c | 1 b/mm/vmalloc.c | 1 b/drivers/staging/lttng/wrapper/kallsyms.h | 2 b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_backend.c | 3 b/drivers/staging/lttng/ltt-context.c | 1 b/drivers/staging/lttng/ltt-debugfs-abi.c | 3 b/drivers/staging/lttng/ltt-events.c | 3 b/drivers/staging/lttng/ltt-ring-buffer-client.h | 3 b/drivers/staging/lttng/ltt-ring-buffer-metadata-client.h | 3 b/drivers/staging/lttng/lttng-context-nice.c | 3 b/drivers/staging/lttng/lttng-context-perf-counters.c | 3 b/drivers/staging/lttng/lttng-context-pid.c | 3 b/drivers/staging/lttng/lttng-context-ppid.c | 3 b/drivers/staging/lttng/lttng-context-prio.c | 3 b/drivers/staging/lttng/lttng-context-procname.c | 3 b/drivers/staging/lttng/lttng-context-tid.c | 3 b/drivers/staging/lttng/lttng-context-vpid.c | 3 b/drivers/staging/lttng/lttng-context-vppid.c | 3 b/drivers/staging/lttng/lttng-context-vtid.c | 3 b/drivers/staging/lttng/lttng-syscalls.c | 2 b/drivers/staging/lttng/probes/lttng-events.h | 3 b/drivers/staging/lttng/probes/lttng-ftrace.c | 5 b/drivers/staging/lttng/probes/lttng-kprobes.c | 3 b/drivers/staging/lttng/probes/lttng-kretprobes.c | 3 b/drivers/staging/lttng/probes/lttng-types.c | 3 drivers/staging/lttng/wrapper/vmalloc.h | 49 -- b/fs/splice.c | 1 b/drivers/staging/lttng/lib/Makefile | 3 b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_splice.c | 3 drivers/staging/lttng/wrapper/splice.c | 46 -- drivers/staging/lttng/wrapper/splice.h | 23 - drivers/staging/lttng/lttng-context-perf-counters.c | 9 drivers/staging/lttng/wrapper/perf.h | 32 - b/drivers/staging/lttng/README | 4 drivers/staging/lttng/ltt-events.c | 11 b/drivers/staging/lttng/probes/Makefile | 4 a/drivers/staging/lttng/probes/lttng-ftrace.c | 187 ---------- drivers/staging/lttng/wrapper/ftrace.h | 70 --- b/drivers/staging/lttng/lib/ringbuffer/frontend_types.h | 1 drivers/staging/lttng/wrapper/spinlock.h | 26 - b/drivers/staging/lttng/ltt-events.h | 3 drivers/staging/lttng/wrapper/uuid.h | 29 - b/kernel/sched.c | 1 drivers/staging/lttng/lttng-context-prio.c | 23 - a/drivers/staging/lttng/wrapper/kallsyms.h | 30 - 49 files changed, 44 insertions(+), 595 deletions(-) Thanks, Mathieu _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel