Re: [PATCH v3 3/3] Staging: bcm: hostmibs: Added temporary variable to shorten lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-11-03 at 21:36 +0300, Dan Carpenter wrote:
> On Thu, Nov 03, 2011 at 07:34:54PM +0200, Joe Perches wrote:
> > On Thu, 2011-11-03 at 12:25 -0300, Diego F. Marfil wrote:
> > > +	t->wmanIfCmnCpsArqWindowSize = ntohs(psfLocalSet->u16ARQWindowSize);
> > > +	t->wmanIfCmnCpsArqWindowSize = ntohl(t->wmanIfCmnCpsArqWindowSize);
> > huh? There are a few of these that don't make much sense to me.
> > ntohs then ntohl?  why?
> > etc...
> Joe, you're obviously right but these arent' bugs that Diego
> introduced so is it Ok if he sends fixes for those in a later patch?

Of course.

The wall of repetitive text probably just obscured
the likely defective use of ntohl(ntohs()).


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux