re: Staging: slicoss: kill functions prototypes and reorder functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[ My script is blaming the wrong patch for this bug...  But I
  figured I would send this email out anyway.  Feel free to ignore
  it. -dan ]

Hello Denis Kirjanov,

This is a semi-automatic email about new static checker warnings.

The patch 4d6ea9c3223d: "Staging: slicoss: kill functions prototypes 
and reorder functions" from Jul 10, 2010, leads to the following 
Smatch complaint:

drivers/staging/slicoss/slicoss.c +941 slic_timer_load_check()
	 warn: variable dereferenced before check 'adapter' (see line 939)

drivers/staging/slicoss/slicoss.c
   938	
   939		intagg = &adapter->slic_regs->slic_intagg;
                          ^^^^^^^^^^^^^^^^^^^^
dereference.

   940	
   941		if ((adapter) && (adapter->state == ADAPT_UP) &&
                     ^^^^^^^
check.

   942		    (card->state == CARD_UP) && (slic_global.dynamic_intagg)) {
   943			if (adapter->devid == SLIC_1GB_DEVICE_ID) {

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux