On Tue, Oct 25, 2011 at 05:59:21PM +0200, Francois Romieu wrote: > Mark Einon <mark.einon@xxxxxxxxx> : > [...] > > The PCIe changes are good, however I think using gotos here doesn't add > > anything as there's no difficult locking to navigate and makes the code > > harder to read. > > both out: and err_out: are used to return an error, and the backwards > > jumping goto makes me a bit uncomfortable. Could you respin with just the > > PCIe changes? > > I confess I use a 55 lines vi split terminal when reviewing these blocks. > > As there is no documentation to check the remaining PCIe candidate bits, > it's probably not worth it anyway. Ok, I'll fixup the changes I highlighted and Ack your original patches, it's not much work to do so. I do have some documentation for the PCI part of the registers (et1310_datasheet.pdf), which you can find online or I can send you a copy if you're interested (I managed to get it from LSI, who bought Agere). I've also been using a datasheet for the truephy ET1011 (also found online) as reference for some of the other registers, which although not exactly the same, is almost identical. You're welcome to a copy of that too. Cheers, Mark _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
