On Tue, Oct 18, 2011 at 7:20 PM, Piotr Chmura <chmooreck@xxxxxxxxxxxxxx> wrote: > On Tue, 18 Oct 2011 11:52:17 -0400 > Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> wrote: > >> On Tue, Oct 18, 2011 at 5:10 AM, Piotr Chmura <chmooreck@xxxxxxxxxxxxxx> wrote: >> > Thanks for comments for all of you. >> > >> > [PATCH 1-12/14] Following your guidelines i exported all changes from hg one by one. This way we will have all history in kernel tree. >> > I moved driver to staging/media and removed Kconfig/Makefile changes in parent directory in first patch. >> >> Hello Piotr, >> >> Not that I want to create more work for you, but it would appear that >> your patches stripped off all the Signed-off-by lines for both myself >> and Pierrick Hascoet (the developer from the hardware vendor). You >> have replaced them with "cc:" lines, which breaks the chain of >> "Developer's Certificate of Origin". >> >> When you take somebody else's patches, you need to preserve any >> existing Signed-off-by lines, adding your own at the bottom of the >> list. >> >> In other words, the first patch should be: >> >> Signed-off-by: Pierrick Hascoet <pierrick.hascoet@xxxxxxxxxx> >> Signed-off-by: Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> >> Signed-off-by: Piotr Chmura <chmooreck@xxxxxxxxxxxxxx> >> >> instead of: >> >> Signed-off-by: Piotr Chmura <chmooreck@xxxxxxxxxxxxxx> >> Cc: Pierrick Hascoet <pierrick.hascoet@xxxxxxxxxx> >> Cc: Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> >> >> Devin >> >> -- >> Devin J. Heitmueller - Kernel Labs >> http://www.kernellabs.com >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Ok, i'll resend them again. > > Should I replay to every patch with something like [RESEND PATCH nn/mm]..., right ? > > Peter Hi Peter, A common convention is to add the version of your patch in the subject like: [PATCH v2 0/14] staging/media/as102: new driver submission That way people can know that is actually a resend of a new patch-set and not a resend of the last one. Anything that is between your Signed-off and the diff get trimmed by Git when applying a patch (that is why Devin and Pierrick Signed-off where stripped in first place). So you can add information about the changes there. Something like: Signed-off-by: Pierrick Hascoet <pierrick.hascoet@xxxxxxxxxx> Signed-off-by: Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> Signed-off-by: Piotr Chmura <chmooreck@xxxxxxxxxxxxxx> ---- v2: preserve any existing Signed-off-by lines so it doesn't get stripped when applied. diff -Nur linux.clean/drivers/staging/as102/as102_drv.c linux.as102_initial/drivers/staging/as102/as102_drv.c --- linux.clean/drivers/staging/as102/as102_drv.c 1970-01-01 01:00:00.000000000 +0100 +++ linux.as102_initial/drivers/staging/as102/as102_drv.c 2011-10-14 17:55:02.000000000 +0200 @@ -0,0 +1,360 @@ +/* + * Abilis Systems Single DVB-T Receiver + * Copyright (C) 2008 Pierrick Hascoet<pierrick.hascoet@xxxxxxxxxx> + * Copyright (C) 2010 Devin Heitmueller<dheitmueller@xxxxxxxxxxxxxx> Hope it helps, -- Javier Martínez Canillas (+34) 682 39 81 69 Barcelona, Spain _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
