On Sun, Oct 16, 2011 at 03:45:19PM +0200, Oren Weil wrote: > 1) we move the AMT Watchdog to use the kernel watchdog core and > it is still part of the MEI Driver, we didn't see any reason to extract it > from the mei driver now with the new watchdog core. Not understandable. You need a few transition words instead of just putting a few unrelated sentences after each other. > 2) since the watchdog is remains in mei driver, exposing in kernel > api just for AMTHI unnecessary. You have a verb (is) too much, and you miss a "the" before "mei driver". "in kernel" should be "in-kernel", "api" should be "API". And you miss an "is" after AMTHI (whatever AMTHI is). > > MEI new Watchdog Core Interface Patches set: > https://lkml.org/lkml/2011/9/7/26 You are missing a verb here. > > 3) Cleanup the code (init and probe, bug_on usage, headers and etc) was > submitted in previous patches. "Code cleanup" instead of "Cleanup the code" > > Patches: > https://lkml.org/lkml/2011/9/21/231 > https://lkml.org/lkml/2011/6/15/358 > https://lkml.org/lkml/2011/7/7/177 > https://lkml.org/lkml/2011/9/7/38 > https://lkml.org/lkml/2011/9/7/37 > https://lkml.org/lkml/2011/9/7/28 > > > 4) mei.txt was update with additional information in previous patches. ^ (missing d) In general, prose text tends to be much more readable than a list of sentences. At least writing a short introduction in prose would be helpful. -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
