On 11/10/11 13:04, Greg KH wrote: > On Tue, Oct 11, 2011 at 12:56:32PM +0100, Martyn Welch wrote: >> On 26/09/11 10:27, Manohar Vanga wrote: >>> Hi, >>> >>> I start by apologizing for my absence recently as I was away on vacation >>> for a few weeks. Picking up where I left off, this is the resend of the >>> two final patches along with some movement of code into additional patches. >>> >>> Martyn, Emilio: Thanks for all the feedback :-) >>> >>> Thanks! >>> Manohar >>> >>> Manohar Vanga (4): >>> staging: vme: add struct vme_dev for VME devices >>> staging: vme: make match() driver specific to improve non-VME64x >>> support >>> staging: vme: get rid of struct vme_device_id and slots >>> staging: vme_user: rename USER_BUS_MAX to VME_USER_BUS_MAX >>> >>> drivers/staging/vme/devices/vme_user.c | 67 +++----- >>> drivers/staging/vme/devices/vme_user.h | 2 +- >>> drivers/staging/vme/vme.c | 284 +++++++++++++++----------------- >>> drivers/staging/vme/vme.h | 50 ++++-- >>> drivers/staging/vme/vme_api.txt | 90 ++++++----- >>> drivers/staging/vme/vme_bridge.h | 6 +- >>> 6 files changed, 246 insertions(+), 253 deletions(-) >>> >> >> Hi Guys, >> >> Sorry for the lack of communication from my end. I've had to take paternity >> leave a little earlier than expected (I wasn't expecting to be AFK for another >> few days). I haven't had a chance to sit down and look over and try out these >> patches as I'd like to. I'll probably be rather tied up for about another week >> I'm afraid... > > No problem, if you don't object, I'll be glad to review these and apply > them if they look sane to me, otherwise I can wait for you to get some > spare time to do so. > > greg k-h Hi Greg, I think that would probably be best, I started to look over the patches before leaving work in a bit of a hurry. Don't think I saw anything that I has overly concerned about. I'd have preferred to have run it up on a board, but in the circumstances I'd prefer not to impede these improvements to the VME driver code. Martyn -- Martyn Welch (Principal Software Engineer) | Registered in England and GE Intelligent Platforms | Wales (3828642) at 100 T +44(0)1327322748 | Barbirolli Square, Manchester, E martyn.welch@xxxxxx | M2 3AB VAT:GB 927559189 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
