Hi Dan, On Fri, Oct 7, 2011 at 4:30 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Fri, Oct 07, 2011 at 09:29:23AM -0400, Kevin McKinney wrote: >> Thanks for the feedback. I will fix and resubmit ASAP. I assume >> BcmFileDownload returns a true when successful, so perhaps it should >> be "if (!status)" ? Either way, I will confirm, fix, and resubmit. >> > > BcmFileDownload() returns 0 on success and negative error codes on > failure. It's best not to assume things, I guess... > Yes, I have the patch rewritten; and in the process of resubmitting. Also, I will never submit a patch based on my assumptions; I will always confirm. Thanks, Kevin _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
