Re: [PATCH 4/4] Staging: bcm: Fix assignment vs. condition bug reported by checkpatch.pl.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 07, 2011 at 09:29:23AM -0400, Kevin McKinney wrote:
> Thanks for the feedback.  I will fix and resubmit ASAP.  I assume
> BcmFileDownload returns a true when successful, so perhaps it should
> be "if (!status)" ?  Either way, I will confirm, fix, and resubmit.
> 

BcmFileDownload() returns 0 on success and negative error codes on
failure.  It's best not to assume things, I guess...

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux