Re: [PATCH 20/20] staging: brcm80211: reduced checkpatch warnings to zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/19/2011 05:04 PM, Joe Perches wrote:
Splitting format strings is poor style, makes
error messages difficult to find via grep and
is error prone.

You should update your checkpatch version.
Current checkpatch doesn't warn about this.

Thank you for pointing this out.

It'd be better if you could find some way
to reduce the 6 tab indentation rather than
split 20 char format strings into pieces.

Greg, could you please drop this one? We will take care of the indentation issue in future patches.

Thanks,
Franky

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux