On Mon, 2011-09-19 at 14:26 -0700, Franky Lin wrote: > Both community and Broadcom patches introduced checkpatch warnings. > --- > diff --git a/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c b/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c > index 1cbdb80..bff5066 100644 > --- a/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c > +++ b/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c > @@ -96,7 +96,8 @@ int brcmf_sdioh_request_byte(struct brcmf_sdio_dev *sdiodev, uint rw, uint func, > (sdiodev->func[2]); > if (err_ret) > brcmf_dbg(ERROR, > - "enable F2 failed:%d\n", > + "enable F2 " > + "failed:%d\n", Just about all of this patch is not good. Splitting format strings is poor style, makes error messages difficult to find via grep and is error prone. You should update your checkpatch version. Current checkpatch doesn't warn about this. It'd be better if you could find some way to reduce the 6 tab indentation rather than split 20 char format strings into pieces. > @@ -105,7 +106,8 @@ int brcmf_sdioh_request_byte(struct brcmf_sdio_dev *sdiodev, uint rw, uint func, > - "Disable F2 failed:%d\n", > + "Disable F2 " > + "failed:%d\n", etc. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
