On 09/12/2011 03:06 PM, Dan Carpenter wrote:
On Mon, Sep 12, 2011 at 12:14:53PM +0200, Roland Vossen wrote:- cfg80211_dev = kzalloc(sizeof(struct brcmf_cfg80211_dev), GFP_KERNEL); - if (unlikely(!cfg80211_dev)) { + cfg_dev = kzalloc(sizeof(struct brcmf_cfg80211_dev), GFP_KERNEL); + if (unlikely(!cfg_dev)) { WL_ERR("wl_cfg80211_dev is invalid\n");This message is wrong. Also it isn't needed because kzalloc() prints its own more complete message.
Understood. Will remove this in a subsequent patch.
Also unlikely() isn't needed here in the attach function. Likely and unlikely hints only belong in the fast path, and generally shouldn't be included in driver code (only in core kernel code).
I will remove all likely/unlikely instances in the drivers except for places where we think they are justified, which I suspect is in 0 places.
Thanks for the review, Roland. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
