On Mon, Sep 12, 2011 at 12:14:53PM +0200, Roland Vossen wrote:
> - cfg80211_dev = kzalloc(sizeof(struct brcmf_cfg80211_dev), GFP_KERNEL);
> - if (unlikely(!cfg80211_dev)) {
> + cfg_dev = kzalloc(sizeof(struct brcmf_cfg80211_dev), GFP_KERNEL);
> + if (unlikely(!cfg_dev)) {
> WL_ERR("wl_cfg80211_dev is invalid\n");
This message is wrong. Also it isn't needed because kzalloc() prints
its own more complete message.
Also unlikely() isn't needed here in the attach function. Likely and
unlikely hints only belong in the fast path, and generally shouldn't
be included in driver code (only in core kernel code).
Don't resend the patch obviously since this was there in the
original code.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
