On 09/09/2011 07:10 PM, Greg KH wrote: > On Fri, Sep 09, 2011 at 07:01:02PM -0400, Nitin Gupta wrote: >> Global variables 'num_devices' and 'devices' are too >> general to be global. This patch switches the name to >> be "zram_devices". >> >> Signed-off-by: Noah Watkins <noahwatkins@xxxxxxxxx> >> Signed-off-by: Nitin Gupta <ngupta@xxxxxxxxxx> > > I've already applied this patch, right? > I just checked another (staging-next) tree which is sync'ed more recently and yes this patch has been applied. Since git.kernel.org seems to be down I couldn't see this change on my working tree. However, that previous change actually also renamed module parameter name 'num_devices' to 'zram_num_devices' which does not make much sense since the boot parameter would now be 'zram.zram_num_devices='. All that's needed is to rename that global variable to some less generic name but the boot/command line parameter name should be retained as 'zram.num_devices=' which is what this new patch does. So, would it possible for you to back-out that original change and apply this change instead. Or, should I send a new patch series that "fixes" that previous change? Nitin _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
