On 09/09/2011 07:12 PM, Greg KH wrote: > On Fri, Sep 09, 2011 at 07:01:04PM -0400, Nitin Gupta wrote: >> Currently, we set initial disksize as 0, which forces >> user to write some value to corresponding zram device's >> sysfs node, before the device can be used. Now, we avoid >> this step by providing some default size initially. >> >> To change the disksize, user must: >> - Reset disk. >> Ex: echo 1 > /sys/block/zram0/reset >> (NOTE: disksize is set to the default value after reset) >> >> - Set new disksize. >> Ex: echo $((256*1024*1024)) > /sys/block/zram0/disksize > > So, what tools just broke with this change? > > And where is the sysfs file documentation change that should go along > with this? > This change does not change any sysfs names or behavior, so does not break any scripts that assume the current behavior. I also verified that sysfs documentation (ABI/testing/sysfs-block-zram) need not be changed and same with drivers/staging/zram/zram.txt. PS: zram_set_disksize() change (patch 1/5) also does not break any documentation. Thanks, Nitin _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel