On Wed, Aug 17, 2011 at 12:02:20PM -0700, pradheep.sh@xxxxxxxxx wrote:
> From: Pradheep <pradheep.sh@xxxxxxxxx>
>
> The patch fixes the checkpatch.pl errors , braces , whitespaces and usleep
>
> Signed-off-by: pradheep.sh@xxxxxxxxx
> ---
> drivers/staging/go7007/go7007-usb.c | 2 +-
> drivers/staging/go7007/go7007-v4l2.c | 2 +-
> drivers/staging/go7007/s2250-board.c | 3 +-
> drivers/staging/go7007/s2250-loader.c | 6 ++--
> drivers/staging/go7007/saa7134-go7007.c | 34 ++++++++++++++++--------------
> drivers/staging/go7007/wis-ov7640.c | 3 +-
> drivers/staging/go7007/wis-saa7113.c | 3 +-
> drivers/staging/go7007/wis-saa7115.c | 3 +-
> drivers/staging/go7007/wis-tw2804.c | 6 +---
> drivers/staging/go7007/wis-tw9903.c | 6 ++--
> 10 files changed, 32 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/staging/go7007/go7007-usb.c b/drivers/staging/go7007/go7007-usb.c
> index 3db3b0a..22b78b6 100644
> --- a/drivers/staging/go7007/go7007-usb.c
> +++ b/drivers/staging/go7007/go7007-usb.c
> @@ -632,7 +632,7 @@ static int go7007_usb_ezusb_write_interrupt(struct go7007 *go,
> __le16_to_cpus(&status_reg);
> if (!(status_reg & 0x0010))
> break;
> - msleep(10);
> + udelay(10000);
> }
> if (i == 100) {
> printk(KERN_ERR
> diff --git a/drivers/staging/go7007/go7007-v4l2.c b/drivers/staging/go7007/go7007-v4l2.c
> index 2b27d8d..fcb701b 100644
> --- a/drivers/staging/go7007/go7007-v4l2.c
> +++ b/drivers/staging/go7007/go7007-v4l2.c
> @@ -606,7 +606,7 @@ static int vidioc_querycap(struct file *file, void *priv,
> strlcpy(cap->driver, "go7007", sizeof(cap->driver));
> strlcpy(cap->card, go->name, sizeof(cap->card));
> #if 0
> - strlcpy(cap->bus_info, dev_name(&dev->udev->dev), sizeof(cap->bus_info));
> +strlcpy(cap->bus_info, dev_name(&dev->udev->dev), sizeof(cap->bus_info));
This is not correct, sorry.
Please do one patch per logical change. It's easier to review and
apply. Care to redo this patch in that manner?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
