On Wed, Aug 17, 2011 at 12:02:20PM -0700, pradheep.sh@xxxxxxxxx wrote:
> From: Pradheep <pradheep.sh@xxxxxxxxx>
>
> The patch fixes the checkpatch.pl errors , braces , whitespaces and usleep
Don't mix whitespace changes and behavior changes.
Have you tested this? The changes to msleep need more justification.
>
> Signed-off-by: pradheep.sh@xxxxxxxxx
Not in the right format.
> diff --git a/drivers/staging/go7007/go7007-v4l2.c b/drivers/staging/go7007/go7007-v4l2.c
> index 2b27d8d..fcb701b 100644
> --- a/drivers/staging/go7007/go7007-v4l2.c
> +++ b/drivers/staging/go7007/go7007-v4l2.c
> @@ -606,7 +606,7 @@ static int vidioc_querycap(struct file *file, void *priv,
> strlcpy(cap->driver, "go7007", sizeof(cap->driver));
> strlcpy(cap->card, go->name, sizeof(cap->card));
> #if 0
> - strlcpy(cap->bus_info, dev_name(&dev->udev->dev), sizeof(cap->bus_info));
> +strlcpy(cap->bus_info, dev_name(&dev->udev->dev), sizeof(cap->bus_info));
> #endif
The original was correct.
> @@ -152,16 +152,17 @@ static int saa7134_go7007_interface_reset(struct go7007 *go)
>
> saa_writeb(SAA7134_GPIO_GPSTATUS2, GPIO_COMMAND_REQ1);
> saa_writeb(SAA7134_GPIO_GPSTATUS2, GPIO_COMMAND_RESET);
> - msleep(1);
> + udelay(1000);
> saa_writeb(SAA7134_GPIO_GPSTATUS2, GPIO_COMMAND_REQ1);
> saa_writeb(SAA7134_GPIO_GPSTATUS2, GPIO_COMMAND_REQ2);
> - msleep(10);
> + udelay(1000);
10 ms is 10000 usec, but you wrote 1000.
> @@ -118,7 +117,8 @@ static int wis_tw9903_command(struct i2c_client *client,
> {
> struct video_decoder_resolution *res = arg;
> /*int hscale = 256 * 720 / res->width;*/
> - int hscale = 256 * 720 / (res->width - (res->width > 704 ? 0 : 8));
> + int hscale = 256 * 720
> + /(res->width - (res->width > 704 ? 0 : 8));
^
missing a space here. Maybe put the / on the line before as well.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
