W dniu 12 sierpnia 2011 18:37 użytkownik Arend van Spriel
<arend@xxxxxxxxxxxx> napisał:
> On 08/12/2011 04:12 PM, Rafał Miłecki wrote:
>>
>> 2011/8/12 Arend van Spriel<arend@xxxxxxxxxxxx>:
>>>
>>> @@ -273,7 +270,6 @@ extern int brcmf_sdioh_interrupt_deregister(struct
>>> sdioh_info *sd)
>>> /* IOVar table */
>>> enum {
>>> IOV_MSGLEVEL = 1,
>>> - IOV_BLOCKSIZE,
>>> IOV_NUMINTS,
>>> IOV_DEVREG,
>>> IOV_HCIREGS,
>>
>> You are forcing IOV_MSGLEVEL to 1, so I expected values of IOV_* are
>> really important in some piece of code. Now you change them. AFAIU it
>> means you break something, or you can drop " = 1".
>
> IOCTL codes do have a strong ordering as user-space application and driver
> need to have the same code for the same entity. IOVs are internal numbers
> for the driver only so there is no issue in renumbering those.
Then you can note dropping " = 1" to avoid confusion for
new-code-readers :) For your TODO.
--
Rafał
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
