Re: [PATCH 02/14] staging: brcm80211: remove iovar IOV_BLOCKSIZE in brcmfmac

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/12/2011 04:12 PM, Rafał Miłecki wrote:
2011/8/12 Arend van Spriel<arend@xxxxxxxxxxxx>:
@@ -273,7 +270,6 @@ extern int brcmf_sdioh_interrupt_deregister(struct sdioh_info *sd)
  /* IOVar table */
  enum {
        IOV_MSGLEVEL = 1,
-       IOV_BLOCKSIZE,
        IOV_NUMINTS,
        IOV_DEVREG,
        IOV_HCIREGS,
You are forcing IOV_MSGLEVEL to 1, so I expected values of IOV_* are
really important in some piece of code. Now you change them. AFAIU it
means you break something, or you can drop " = 1".

IOCTL codes do have a strong ordering as user-space application and driver need to have the same code for the same entity. IOVs are internal numbers for the driver only so there is no issue in renumbering those.

Gr. AvS

--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux