On 03/08/11 16:23, Emilio G. Cota wrote: > On Wed, Aug 03, 2011 at 16:06:30 +0200, Manohar Vanga wrote: >> Hey Martyn, >> >>> Can we not do this inside vme_master_request, vme_slave_request, etc? >>> >>> I.e. Add reference count when resources are given out. >>> >>> This would then be done in the vme_*_free routines. >> >> I agree this would be much better. I will change this and resend :) > > To me it seems better to keep this as is, to be > used by .probe and .release methods, in the same way > usb_get_dev() and usb_put_dev() are used by usb drivers. > The description of the functions in usb.c suggests, to me at least, that these functions are the equivalent to the vme_*_request functions in the vme code. Being called when a function binds to an interface and when it is finished with it. Martyn -- Martyn Welch (Principal Software Engineer) | Registered in England and GE Intelligent Platforms | Wales (3828642) at 100 T +44(0)127322748 | Barbirolli Square, Manchester, E martyn.welch@xxxxxx | M2 3AB VAT:GB 927559189 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel