On Wed, Aug 03, 2011 at 16:06:30 +0200, Manohar Vanga wrote: > Hey Martyn, > > > Can we not do this inside vme_master_request, vme_slave_request, etc? > > > > I.e. Add reference count when resources are given out. > > > > This would then be done in the vme_*_free routines. > > I agree this would be much better. I will change this and resend :) To me it seems better to keep this as is, to be used by .probe and .release methods, in the same way usb_get_dev() and usb_put_dev() are used by usb drivers. Hiding refcounts under the resource accessors will just complicate things unnecessarily. Modifying refcounts should always be explicit unless there's a very good reason against it. Emilio _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
