Re: GMA500: ERROR: "__bad_udelay" undefined!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Don't know yet - its on the fixme list to dig into - I think the answer
> > is some cases but not all.
> 
> IMO, it should be replaced with actually waiting for the vblank and not an
> arbitrary time. I think this is fine as long as we don't use it when waiting for
> a pipe to disable. And I guess we could sleep while waiting for vblank.

Opinions are cheap, generating a list of all the paths through the tree
that can hit vblank waits is alas not, neither is verifying it on a pile
of real hardware 8(

Plus none of the Intel issued IMG drivers wait for a vblank event and in
several cases it's quite clear that there is *no* vblank that can be
waited for at that point, eg look at the MIPI interfaces.

So unfortunately it's rather complicated to fix although working them
through to make some of the msleeps is certainly doable - add a
sleep_for_vblank() or similar and send patches as you verify each one is
ok and test it perhaps ?

Alan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux