On 07/16/2011 01:49 AM, Dan Carpenter wrote:
On Thu, Jul 14, 2011 at 02:29:31PM -0700, Franky Lin wrote:
--- a/drivers/staging/brcm80211/brcmfmac/dhd_common.c
+++ b/drivers/staging/brcm80211/brcmfmac/dhd_common.c
@@ -827,10 +827,13 @@ static int brcmf_c_pattern_atoh(char *src, char *dst)
return -EINVAL;
}
for (i = 0; *src != '\0'; i++) {
+ unsigned long res;
char num[3];
strncpy(num, src, 2);
num[2] = '\0';
- dst[i] = (u8) simple_strtoul(num, NULL, 16);
+ if (kstrtoul(num, 16,&res))
+ return -1;
^^
Not a proper error code.
Hi Dan,
You are right. I actually had this patch before patch 21, which fixed
the other error paths in the function. This slipped through during
reordering of the patch. Will fix it.
Greg, Please drop this one.
Gr. AvS
--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
