On 07/16/2011 02:06 AM, Dan Carpenter wrote:
@@ -3552,8 +3552,7 @@ void brcms_c_switch_shortslot(struct brcms_c_info *wlc, bool shortslot) if (wlc->shortslot) cfg->current_bss->capability |= WLAN_CAPABILITY_SHORT_SLOT_TIME; - END_FOREACH_BSS - + END_FOREACH_BSS /* this comment fixes a checkpatch warning */I don't have strong feelings about this, but another way to do that would be to write it like: FOR_EACH(blah, blah) { frob(); frob(); frob(); } END_FOREACH_BSS();
Maybe have to revisit the macro definitions. Will look into this. As this patch fixes some true extern warnings I suggest to let this one go in the tree.
Or if you know perl, you could look into why checkpatch is printing the wrong warning here...
I moved on to python scripting and perl got flushed from memory ;-) Gr. AvS -- Almost nobody dances sober, unless they happen to be insane. -- H.P. Lovecraft -- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
