Re: [PATCH 01/24] ath6kl: add bmi.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2011-07-13 at 10:08 +0300, Kalle Valo wrote:
> On 07/13/2011 07:28 AM, Joe Perches wrote:
> > On Wed, 2011-07-13 at 04:33 +0300, Kalle Valo wrote: 
> >> diff --git a/drivers/net/wireless/ath/ath6kl/bmi.c b/drivers/net/wireless/ath/ath6kl/bmi.c
> > [] 
> >> +			ath6kl_err("Unable to decrement the command "
> >> +				   "credit count register: %d\n", ret);
> > I think all of these ath6kl_<level> uses in all the patches
> > should coalesce formats that are split across multiple lines.
> > This helps grepping the sources for a specific dmesg.
> > 			ath6kl_err("Unable to decrement the command credit count register: %d\n",
> > 				   ret);
> I agree, that would improve readibility. The reason why the lines were
> split is because of checkpatch warnings. I could unsplit them but then
> someone else might start complaining about high number checkpatch
> warnings about long lines. So I really don't know what to do with them.

Add this patch to checkpatch?
I'll submit it to Andrew Morton later.

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b0aa2c6..c0be3c5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -210,7 +210,7 @@ our $typeTypedefs = qr{(?x:
 
 our $logFunctions = qr{(?x:
 	printk|
-	[a-z]+_(emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)|
+	[a-z0-9]+_(emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)|
 	WARN|
 	panic|
 	MODULE_[A-Z_]+



_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux