On 07/13/2011 07:28 AM, Joe Perches wrote:
> On Wed, 2011-07-13 at 04:33 +0300, Kalle Valo wrote:
>> diff --git a/drivers/net/wireless/ath/ath6kl/bmi.c b/drivers/net/wireless/ath/ath6kl/bmi.c
> []
>> + ath6kl_err("Unable to decrement the command "
>> + "credit count register: %d\n", ret);
>
> I think all of these ath6kl_<level> uses in all the patches
> should coalesce formats that are split across multiple lines.
> This helps grepping the sources for a specific dmesg.
>
> ath6kl_err("Unable to decrement the command credit count register: %d\n",
> ret);
I agree, that would improve readibility. The reason why the lines were
split is because of checkpatch warnings. I could unsplit them but then
someone else might start complaining about high number checkpatch
warnings about long lines. So I really don't know what to do with them.
Kalle
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
